Choropleth Counties #929
Choropleth Counties #929
Conversation
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
there are a lot of extra newlines added at the bottom of this file
plotly/version.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = '2.3.0' | |||
| __version__ = '2.3.1' | |||
There was a problem hiding this comment.
I believe this should be 2.4.0 https://semver.org/
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| import numpy as np | |||
| from scipy.spatial import Delaunay | |||
| import os | |||
There was a problem hiding this comment.
did os need to be imported for the added choropleth test? It doesn't look like it below.
| fig['layout']['yaxis']['range'][0] = center[1] - new_height * 0.5 | ||
| fig['layout']['yaxis']['range'][1] = center[1] + new_height * 0.5 | ||
|
|
||
| return fig |
There was a problem hiding this comment.
newline at the end of file recommended
|
Do we need this xml file? |
|
Just to confirm, the current version of this FigureFactory in this PR generates these plots? |
| @@ -557,7 +557,7 @@ def create_choropleth(fips, values, scope=['usa'], binning_endpoints=None, | |||
| """ | |||
| # ensure optional modules imported | |||
| if not gp or not shapefile or not shapely: | |||
| raise ImportError("geopandas, shapefile and shapely must be " | |||
| raise ImportError("geopandas, pyshp and shapely must be " | |||
| "installed for this figure factory") | |||
There was a problem hiding this comment.
Should we add the pip statements here? For example, "Try pip install geopandas and pip install pyshp in your terminal."
There was a problem hiding this comment.
good idea. we can add it to the docs as well to remind in two places
There was a problem hiding this comment.
Just to confirm
confirmed
|
There's a mismatch between this notebook and the plots. I think you updated the plots, but didn't upload the new notebook: https://plot.ly/~AdamKulidjian/6680 Mind uploading the latest? |
|
💃 After considering the comments above. Great work on this one. By far the easiest way to make interactive choropleth maps in Python to the best of my knowledge. 🥂
|
Here's the latest notebook: https://plot.ly/~AdamKulidjian/6681 |
Re: #897